Skip to content

Closes #2003: Fix NXOS ping source_interface bugs #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Closes #2003: Fix NXOS ping source_interface bugs #2004

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
88d19dd
Closes #2003: Fix NXOS ping source_interface bugs
decoupca Sep 6, 2023
0923ffa
black
decoupca Sep 6, 2023
7cbcbb9
Merge branch 'napalm-automation:develop' into 2003-fix-nxos-ping
decoupca Sep 14, 2023
e017bce
Fix bug where source_interface and vrf are both provided
decoupca Sep 14, 2023
fdbbf4d
Merge branch '2003-fix-nxos-ping' of github.com:decoupca/napalm into …
decoupca Sep 14, 2023
cb5a259
Merge branch 'develop' into 2003-fix-nxos-ping
mirceaulinic Mar 21, 2024
29e214b
Merge branch 'develop' into 2003-fix-nxos-ping
mirceaulinic Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions napalm/nxos/nxos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,14 +369,18 @@ def ping(
if source != "":
command += " source {}".format(source)
elif source_interface != "":
command += " source {}".format(source_interface)

if vrf != "":
command += " vrf {}".format(vrf)
command += " source-interface {}".format(source_interface)

# source_interface and vrf are mutually exclusive, but since they
# provide the same behavior, no need to raise an exception--just
# prefer source_interface.
if not source_interface:
if vrf != "":
command += " vrf {}".format(vrf)
output = self._send_command(command, raw_text=True)
assert isinstance(output, str)

if "connect:" in output:
if "connect:" in output.lower() or "invalid" in output.lower():
ping_dict["error"] = output
elif "PING" in output:
ping_dict["success"] = {
Expand Down