Skip to content

IOSDriver should catch "Rollback aborted" case when using configure replace #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

IOSDriver should catch "Rollback aborted" case when using configure replace #1701

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f667289
Merge remote-tracking branch 'napalm-automation/develop' into develop
rbcollins123 Jul 8, 2022
65fe99c
Merge remote-tracking branch 'napalm-automation/develop' into develop
rbcollins123 Jul 12, 2022
41c652f
gen exception when configure replace fails with rollback error
rbcollins123 Jul 12, 2022
1383572
Merge branch 'develop' into fix_ios_config_replace_exception
ktbyers Aug 25, 2022
53db5a9
add napalm rollback() when IOS config-replace auto-rollback fails
rbcollins123 Aug 29, 2022
26f92d3
fix linter/formatting errors
rbcollins123 Aug 29, 2022
9467bc6
Merge remote-tracking branch 'napalm-automation/develop' into fix_ios…
rbcollins123 Dec 12, 2022
9f81b1d
Merge branch 'develop' into fix_ios_config_replace_exception
rbcollins123 Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions napalm/ios/ios.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,13 @@ def commit_config(self, message="", revert_in=None):
):
msg = "Candidate config could not be applied\n{}".format(output)
raise ReplaceConfigException(msg)
elif "rollback aborted" in output.lower():
msg = (
"Candidate config could not be applied, "
"attempting rollback\n{}".format(output)
)
self.rollback()
raise ReplaceConfigException(msg)
elif "%Please turn config archive on" in output:
if revert_in_min:
raise CommitConfirmException(ARCHIVE_DISABLED_MESSAGE)
Expand Down