Skip to content

feat: batch tx to pay fees when unshielding #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mateuszjasiuk
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk commented Jul 8, 2025

Resolves #2207

TODO:

  • unshield correct amount of gas
  • check if we can make batch atomic
  • check why shielded context invalidates after successful tx
  • fix toast
  • check history
  • add ledger check(test ledger without check first)
  • wait for namada_sdk change and implement
  • use the same logic for shielded transfers
  • merge details tiles

How to test?

  • try to unshield/shielded transfer with the regular account - try to use many notes > 6 or sth(you will need to bump the gas)
  • try to unshield/shielded transfer with the ledger - to see jf this change did not break ledger logic
  • try shielding/unshielding/shielded transfers with and without ledger to see if details in extension are correct(tx name, from...to, etc.)

@mateuszjasiuk mateuszjasiuk force-pushed the feat/batch-tx-to-pay-fees-when-unshielding branch from 4bcd676 to 2c863d3 Compare July 14, 2025 10:46
@mateuszjasiuk mateuszjasiuk force-pushed the feat/batch-tx-to-pay-fees-when-unshielding branch from 2c863d3 to 5138ec2 Compare August 1, 2025 08:59
@mateuszjasiuk mateuszjasiuk force-pushed the feat/batch-tx-to-pay-fees-when-unshielding branch from 77ca48e to f7b79c1 Compare August 4, 2025 12:05
@mateuszjasiuk mateuszjasiuk changed the title WIP: feat: batch tx to pay fees when unshielding feat: batch tx to pay fees when unshielding Aug 4, 2025
@mateuszjasiuk mateuszjasiuk marked this pull request as ready for review August 4, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MASP tx can exceed masp_fee_payment_gas_limit
1 participant