Skip to content

Conversation

mdclone-oa
Copy link

fix issue #258

/usr/local/lib/python3.12/site-packages/pandarallel/data_types/dataframe.py:69: FutureWarning: DataFrame.applymap has been deprecated. Use DataFrame.map instead.
return data.applymap(user_defined_function)

change applymap to map and tests

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46fc0e5) 91.37% compared to head (861d0d8) 86.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   91.37%   86.37%   -5.00%     
==========================================
  Files          12       12              
  Lines         580      580              
==========================================
- Hits          530      501      -29     
- Misses         50       79      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdclone-oa mdclone-oa marked this pull request as draft November 21, 2023 14:30
@mdclone-oa mdclone-oa marked this pull request as ready for review November 21, 2023 14:44
@shermansiu
Copy link

Unless we're dropping support for Pandas versions < 2.1, I'm against this, especially since Pandas 2.1 was released relatively recently.

There's also no reason to change the minimum Python version to 3.9...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants