Skip to content

Conversation

ireneea
Copy link
Contributor

@ireneea ireneea commented Oct 3, 2025

Summary

  • Add projects versions status checks
  • Expose project status in the source control endponts

Related Linear tickets, Github issues, and Community forum posts

resolves PAY-3897

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="packages/cli/src/environments.ee/source-control/source-control-import.service.ee.ts">

<violation number="1" location="packages/cli/src/environments.ee/source-control/source-control-import.service.ee.ts:614">
Rule violated: **Prefer Typeguards over Type casting**

Avoid narrowing project.type with an `as` cast here; return the literal `&#39;team&#39;` (or use a guard) to comply with the “Prefer Typeguards over Type casting” rule.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

description: project.description,
icon: project.icon,
filename: getProjectExportPath(project.id, this.projectExportFolder),
type: project.type as 'team', // This is safe because we only select team projects
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule violated: Prefer Typeguards over Type casting

Avoid narrowing project.type with an as cast here; return the literal 'team' (or use a guard) to comply with the “Prefer Typeguards over Type casting” rule.

Prompt for AI agents
Address the following comment on packages/cli/src/environments.ee/source-control/source-control-import.service.ee.ts at line 614:

<comment>Avoid narrowing project.type with an `as` cast here; return the literal `&#39;team&#39;` (or use a guard) to comply with the “Prefer Typeguards over Type casting” rule.</comment>

<file context>
@@ -523,6 +531,95 @@ export class SourceControlImportService {
+			description: project.description,
+			icon: project.icon,
+			filename: getProjectExportPath(project.id, this.projectExportFolder),
+			type: project.type as &#39;team&#39;, // This is safe because we only select team projects
+			owner: {
+				type: &#39;team&#39;,
</file context>
Suggested change
type: project.type as 'team', // This is safe because we only select team projects
type: 'team', // This is safe because we only select team projects
Fix with Cubic

Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 97.14286% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...source-control/source-control-status.service.ee.ts 94.87% 0 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant