-
Notifications
You must be signed in to change notification settings - Fork 46k
feat(editor): New T2W blank state (no-changelog) #20368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 28 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="packages/frontend/editor-ui/src/components/Node/NodeCreation.vue">
<violation number="1" location="packages/frontend/editor-ui/src/components/Node/NodeCreation.vue:101">
This condition now fires `trackUserOpenedAssistant` only when the assistant is already open, so opening the assistant no longer emits the telemetry event. Please invert the check so the open action is still tracked.</violation>
</file>
<file name="packages/frontend/@n8n/design-system/src/components/AskAssistantChat/AskAssistantChat.vue">
<violation number="1" location="packages/frontend/@n8n/design-system/src/components/AskAssistantChat/AskAssistantChat.vue:509">
When the chat first renders with suggestions, the bottom input is not mounted, so onMounted never attaches the ResizeObserver or scroll handler to inputWrapperRef. Later, when the input finally appears, those listeners are still missing, and auto-scroll/input resize handling stops working.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
packages/frontend/@n8n/design-system/src/components/AskAssistantChat/AskAssistantChat.vue
Show resolved
Hide resolved
BundleMonFiles added (2)
Total files change +255.73KB Groups added (2)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Summary
This PR updates the initial experience in the product, rendering both a "add first step" and a "build with AI" button on the canvas. This also requires moving the prompt experience into the side panel, since the canvas now has the two buttons.
Addresses designs in: https://linear.app/n8n/issue/AI-1431/t2w-replace-prompting-area-with-two-entry-points-first-node-and-build
A few of the details that needed to be implemented for this:
CanvasNodeAIPrompt
as it was no longer applicableReview / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)