feat: Update iroh-0.11.x to latest released quinn (b2b930a) #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is newly required for libfuzzer-sys 0.4.9. It is a permissive license similar to the MIT or 3-claused BSD licenses.
On MacOS < 14, with `fast-apple-datapath` feature, calls to
`libc::CMSG_NXTHDR` might continuously return empty (i.e. all zero)
`libc::cmsghdr` instead of a null pointer. This results in a busy loop
in `decode_recv`:
``` rust
let cmsg_iter = unsafe { cmsg::Iter::new(hdr) };
for cmsg in cmsg_iter {
match (cmsg.cmsg_level, cmsg.cmsg_type) {
```
https://github.com/quinn-rs/quinn/blob/b4378bb39dab4b58a1e6a3fea4fff9f87033dab6/quinn-udp/src/unix.rs#L685C1-L687C50
This commit fixes the above, returning a `null_mut()` pointer on an
empty `libc::cmsgdhr`, thus terminating the `cmsg_iter`.
See also mozilla/neqo#2427 for details.
This was the only case where `Instant::now()` is used in quinn-proto or quinn-udp for anything other than tests or rate-limiting logging. Making this change to keep these two crates more IO-agnostic.
We depend on new APIs, e.g. for token logs.
This caused rare flakes in at least single_ack_eliciting_packet_triggers_ack_after_delay by classifying a the connection as active for longer than expected.
This reverts the change that tries to avoid sending a PING frame if there are user datagrams to send. The problem is that the user dataram might not fit in the probe that will be sent. It is possible to do this better, but the quick thing is to accept the extra ping frame, the space wasted because of this is rather minimal. And if a user was sending user datagrams at just the right MTU size it is unlikely they would fit in the next packet anyway since typically the probe packet will end up with a smaller size-limit compared to the MTU.
When needing to send tail-loss probes and building a GSO batch the tail-loss probe should not exceed the GSO segment size.
Also includes getters for the current sizes and a test. Bump version to 0.5.11.
…tu is large enough to batch When a TLP is the first in the batch and initial mtu is large enough to allow for batching it still should stay under the max_datagrams limit
separate certificate's examples out of md file into rs files format
Bumps [url](https://github.com/servo/rust-url) from 2.5.4 to 2.5.7. - [Release notes](https://github.com/servo/rust-url/releases) - [Commits](https://github.com/servo/rust-url/commits) --- updated-dependencies: - dependency-name: url dependency-version: 2.5.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4 to 5. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-java dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.142 to 1.0.143. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.142...v1.0.143) --- updated-dependencies: - dependency-name: serde_json dependency-version: 1.0.143 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
|
I'm surprised this is merging into I was expecting that |
|
when I asked about a reminder to our merge process this is the main branch I meant. I'm going to merge this then and we can decide what our next release will be, while the multipath merge is finished |
…1.x-b2b930a-merges
divagant-martian
force-pushed
the
iroh-0.11.x-b2b930a-merges
branch
from
92658ac to
070b6db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were behind around 170 commits, many many had conflicts. Every commit that had a conflict has an individual merge commit. I would prefer to keep the individual merges for future conflicts. This is because future conflicts will go against the individual merges instead of a messy 170 commit merge that gives truly no info on how the conflict was solved