Fix open path api #123
Merged
Fix open path api #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagant-martian
merged commit b3ebcc7
into
n0-computer:multipath-quinn-0.11.x
11 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of the watcher into the
OpenPathInnerbroke the upwards wake, making the future that handles dealing with the state changes not being polled. Because of this tests that use theopen_pathapi take several seconds, until the runtime decides by chance to poll the future. By changing this to store a stream (an actual future, until a watcher, the futures are now polled in a timelly matter. The test for address discovery for examples used to take 30.22seconds, now it's 0.22 secondsThis also simplifies the code by watching for changes instead of values, which removes the need to deal with
Nones that will never happen