Skip to content

Fix for Click-to-Copy #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
swainn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for Click-to-Copy #15

swainn wants to merge 1 commit into from

Conversation

@swainn
Copy link

@swainn swainn commented Sep 4, 2020

This is a fix for #8. This pull request:

  • Modifies the click-to-copy functionality to only copy when the click occurs over the click-to-copy button.
  • This allows users to selectively copy from the code block if they would like or copy the entire block by pressing the click-to-copy button.
  • This is done by comparing the event offsets to see if the coordinates fall with in the approximate area of the button.

@swainn
Modifies the click-to-copy functionality to only copy when the click …
9669cf6 
…occurs over the click-to-copy button.

This allows users to selectively copy from the code block if they would like or copy the entire block by pressing the click-to-copy button.
@maicodelphi
Copy link

maicodelphi commented Nov 9, 2020

Thats a great improvement.
@myyasuda could you merge this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swainn @maicodelphi