Skip to content

Conversation

bakajikara
Copy link
Contributor

@bakajikara bakajikara commented Oct 11, 2025

Resolves: #30449

actualBeamMode will now return the interpreted value for all ChordRests instead of BeamMode::AUTO.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@bakajikara
Copy link
Contributor Author

The failed unit tests reflect differences in how beam is applied in corrupted files, but I don't believe this will cause significant issues.
Now that actualBeamMode returns BeamMode::MID instead of BeamMode::AUTO, the beam will connect even in situations where a1->endTick() < cr->tick() (I believe this only happens with corrupted files, but is that correct?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API: actualBeamMode is not functioning correctly

1 participant