Show localized Piano Keyboard key names

[SilverGreen93]

Partially resolves: #30167 (Part 2)

The C piano keys in the Piano Keyboard panel are always shown in standard pitch notation.

Display the notes with respect to locale by using the strings from global/pitchName.

Piano keyboard with Romanian locale:

Piano keyboard with German locale:

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[SilverGreen93]

Updated this PR as well based on the comment from #30415

[Jojo-Schmitz]

That's a very cheap fix, I like it ;-)

[Jojo-Schmitz]

Downside: for other languages it might look like

Here the added space seems a bit disturbing?

[SilverGreen93]

Here the added space seems a bit disturbing?

For SPN notation, I removed the space in #30530, so it looks better.

[SilverGreen93]

Here the added space seems a bit disturbing?

I removed spaces from all my PRs. It is better this way. Logic is easier.

[Jojo-Schmitz]

BTW, Mu4 seems lacking Mu3's notename tooltips for the piano keyboard:

(along with the advanced setting to switch this off)

[cbjeukendrup]

I believe this is unsafe, because the std::string is destructed immediately after c_str() has been called, meaning that the pointer passed to qtrc is dangling. This would be solved by making octaveLabel immediately a std::string instead of QString, because then the lifetime of the std::string and its data is until the end of the scope, which is enough here.

[Jojo-Schmitz]

Or make it static ;-)

[cbjeukendrup]

I don't think that would solve anything, would it? (and octaveNumber isn't static either)

[Jojo-Schmitz]

Probably, but how is this here different from

MuseScore/src/notation/internal/instrumentsrepository.cpp

Line 226 in 790e749

preset.name = muse::trc("instruments/stringTunings", presetObj.value("name").toStdString().c_str());

Or is that simply having the same issue?

[cbjeukendrup]

I think that has the same issue indeed (but in practice, it probably only leads to a crash very seldom, because even though the std::string's memory is deleted, it is not immediately removed or filled with garbage).

[SilverGreen93]

MuseScore/src/notation/internal/instrumentsrepository.cpp

I saw that as well, but I think @cbjeukendrup is right, seems to be a dangling pointer issue. Will fix accordingly. Thanks!