-
Notifications
You must be signed in to change notification settings - Fork 151
Update signing providers #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Update signing providers #1149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates documentation to provide better guidance for users when working with signing providers and fixes various grammar issues throughout the sdk-dapp documentation.
- Adds context and examples for users to start with when implementing signing providers
- Corrects multiple spelling and grammar errors in the sdk-dapp documentation
- Improves code formatting and structure consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/sdk-and-tools/sdk-js/sdk-js-signing-providers.md | Adds recommended template examples for different frameworks to guide users before implementing signing providers |
| docs/sdk-and-tools/sdk-dapp/sdk-dapp.md | Fixes numerous spelling, grammar, and formatting issues throughout the documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The merge-base changed after approval.
Description of the pull request (what is new / what has changed)
When users read the signing providers page, they need more context about what to start with instead of jumping into implementing signing providers themselves
This PR also fixes some grammar issues in sdk-dapp docs
Did you test the changes locally ?
Which category (categories) does this pull request belong to?