Skip to content

Conversation

@arhtudormorar
Copy link
Contributor

Description of the pull request (what is new / what has changed)

When users read the signing providers page, they need more context about what to start with instead of jumping into implementing signing providers themselves

This PR also fixes some grammar issues in sdk-dapp docs

Did you test the changes locally ?

  • yes
  • no

Which category (categories) does this pull request belong to?

  • document new feature
  • update documentation that is not relevant anymore
  • add examples or more information about a component
  • fix grammar issues
  • other

radumojic
radumojic previously approved these changes Sep 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates documentation to provide better guidance for users when working with signing providers and fixes various grammar issues throughout the sdk-dapp documentation.

  • Adds context and examples for users to start with when implementing signing providers
  • Corrects multiple spelling and grammar errors in the sdk-dapp documentation
  • Improves code formatting and structure consistency

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/sdk-and-tools/sdk-js/sdk-js-signing-providers.md Adds recommended template examples for different frameworks to guide users before implementing signing providers
docs/sdk-and-tools/sdk-dapp/sdk-dapp.md Fixes numerous spelling, grammar, and formatting issues throughout the documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

andreibancioiu
andreibancioiu previously approved these changes Sep 11, 2025
@arhtudormorar arhtudormorar dismissed stale reviews from andreibancioiu and radumojic September 12, 2025 12:59

The merge-base changed after approval.

@arhtudormorar arhtudormorar changed the base branch from main to development September 15, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants