Skip to content

Implement with() in terms of push() #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement with() in terms of push() #129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bed77f
Implement with() in terms of push()
nabijaczleweli Oct 21, 2025
e24eb1c
Fix critical(?) mismatched_lifetime_syntaxes
nabijaczleweli Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,7 @@ impl Multiaddr {

/// Like [`Multiaddr::push`] but consumes `self`.
pub fn with(mut self, p: Protocol<'_>) -> Self {
let mut bytes = BytesMut::from(std::mem::take(&mut self.bytes));
p.write_bytes(&mut (&mut bytes).writer())
.expect("Writing to a `BytesMut` never fails.");
self.bytes = bytes.freeze();
self.push(p);
self
}

Expand Down Expand Up @@ -223,7 +220,7 @@ impl Multiaddr {
/// Returns &str identifiers for the protocol names themselves.
/// This omits specific info like addresses, ports, peer IDs, and the like.
/// Example: `"/ip4/127.0.0.1/tcp/5001"` would return `["ip4", "tcp"]`
pub fn protocol_stack(&self) -> ProtoStackIter {
pub fn protocol_stack(&self) -> ProtoStackIter<'_> {
ProtoStackIter { parts: self.iter() }
}
}
Expand Down