fix(meta): cleanup description meta tags #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for multi-site-app-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for multi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for datami-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for multi-site-preprod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
raphodn
commented
Jun 14, 2024
| const siteTitle = this.config.data.app_name | ||
| const routeName = this.routeName | ||
| const pageKeywords = this.routeKeywords | ||
| const pageDescription = this.routeDescription ?? `${siteTitle} | ${routeName}` |
There was a problem hiding this comment.
there is already a default description set here
✅ Deploy Preview for multi-site-preprod-core-texts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for datami ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
raphodn
commented
Jun 14, 2024
| meta: [ | ||
| { charset: 'utf-8' }, | ||
| { name: 'viewport', content: 'width=device-width, initial-scale=1' }, | ||
| { hid: 'description', name: 'description', content: `${config.appTitle}, multi, multi.coop, multi-site-app` }, |
There was a problem hiding this comment.
current change doesn't seem to have solved the issue, now there is no meta description displayed 😅 (PR 44, 43 is another PR to compare)
raphodn
force-pushed
the
raphodn/meta-description
branch
from
fa7b826 to
9845997
Compare
raphodn
force-pushed
the
raphodn/meta-description
branch
from
c477e2a to
19bbce7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8 & multi-coop/multi-site-contents#90
There is an issue on how the
descriptionmeta tag is generated :multi, multi, multi.coop, multi-site-app