-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[charts] Improve line chart rendering performance for large datasets #17534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] Improve line chart rendering performance for large datasets #17534
Conversation
Thanks for adding a type label to the PR! 👍 |
Please add one type label to categorize the purpose of this PR appropriately:
|
Deploy preview: https://deploy-preview-17534--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #17534 will not alter performanceComparing Summary
|
a6de104
to
5c3e538
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging #17534 will improve performances by 23%
It's really cool to see the performance CI to catch the improvement. That's a healthy cycle.
I think most improvements in this PR are from this commit, so moved it to a separate PR to isolate the changes and make it easier to compare. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
117414c
to
d1c50e4
Compare
d1c50e4
to
2e7b31d
Compare
2e7b31d
to
b28e209
Compare
Part of #12960.
Improve line chart rendering performance for large datasets by using
for
loops andfor...of
instead of.map()
and.filter
. The latter create intermediate arrays and usually hinder performance when dealing with large amounts of data.