Skip to content

[charts] Improve line chart rendering performance for large datasets #17534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bernardobelchior
Copy link
Member

@bernardobelchior bernardobelchior commented Apr 24, 2025

Part of #12960.

Improve line chart rendering performance for large datasets by using for loops and for...of instead of .map() and .filter. The latter create intermediate arrays and usually hinder performance when dealing with large amounts of data.

@bernardobelchior bernardobelchior added performance component: charts This is the name of the generic UI component, not the React module! labels Apr 24, 2025
Copy link

github-actions bot commented Apr 24, 2025

Thanks for adding a type label to the PR! 👍

Copy link

Please add one type label to categorize the purpose of this PR appropriately:

docs, release, bug, regression, maintenance, dependencies, enhancement or new feature

@bernardobelchior bernardobelchior added the enhancement This is not a bug, nor a new feature label Apr 24, 2025
@mui-bot
Copy link

mui-bot commented Apr 24, 2025

Deploy preview: https://deploy-preview-17534--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b28e209

Copy link

codspeed-hq bot commented Apr 24, 2025

CodSpeed Performance Report

Merging #17534 will not alter performance

Comparing bernardobelchior:improv-mark-plot-perf (b28e209) with master (de791e3)

Summary

✅ 8 untouched benchmarks

@bernardobelchior bernardobelchior force-pushed the improv-mark-plot-perf branch 2 times, most recently from a6de104 to 5c3e538 Compare April 24, 2025 18:33
@oliviertassinari oliviertassinari changed the title [charts] improve line chart rendering performance for large datasets [charts] Improve line chart rendering performance for large datasets Apr 24, 2025
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging #17534 will improve performances by 23%

It's really cool to see the performance CI to catch the improvement. That's a healthy cycle.

@bernardobelchior
Copy link
Member Author

I think most improvements in this PR are from this commit, so moved it to a separate PR to isolate the changes and make it easier to compare.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 30, 2025
@bernardobelchior bernardobelchior force-pushed the improv-mark-plot-perf branch from 117414c to d1c50e4 Compare May 2, 2025 12:38
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 2, 2025
@bernardobelchior bernardobelchior force-pushed the improv-mark-plot-perf branch from d1c50e4 to 2e7b31d Compare May 2, 2025 12:39
@bernardobelchior bernardobelchior force-pushed the improv-mark-plot-perf branch from 2e7b31d to b28e209 Compare May 2, 2025 12:40
@bernardobelchior bernardobelchior deleted the improv-mark-plot-perf branch May 2, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants