Change data paths according to semantic.work conventions #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Persist the update handler's state in /data instead of /config - Mount files in /share instead of /data
nvdk
reviewed
Sep 4, 2025
| volumes: | ||
| - ./config/search:/config | ||
| - ./data/search:/data | ||
| - ./data/files:/share # in case your index files |
Member
There was a problem hiding this comment.
small typo here
Suggested change
| - ./data/files:/share # in case your index files | |
| - ./data/files:/share # in case you index files |
nvdk
reviewed
Sep 4, 2025
| - ./config/search:/config | ||
| - ./data/search:/data | ||
| - ./data/files:/share # in case your index files | ||
| - ./data/tika/cache:/cache # in case your index files |
Member
There was a problem hiding this comment.
Suggested change
| - ./data/tika/cache:/cache # in case your index files | |
| - ./data/tika/cache:/cache # in case you index files |
nvdk
reviewed
Sep 4, 2025
Member
nvdk
left a comment
nvdk
left a comment
There was a problem hiding this comment.
I guess this needs to be done, though in the past we opted to have the update-store in config specifically for backwards compatibility (and not having to change the file mount path).
I think this PR could be improved by some startup checks so we can warn users if they have not properly moved the update store or if we detect other files than the update-store in /data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change paths of mounted folders to be more in line with other services:
/datainstead of/config/shareinstead of/dataThis is a breaking change. Tried to be backwards compatible but it's very hard since the user has to update the mount points in
docker-compose.yml. An upgrade path is documented in the changelog.