[WIP] Remove subprocess usage from discovery #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the usage of subprocess from the discovery/list test phase in TestProcessor. Previously to get a list of tests from discovery we would subprocess out to a new python interpreter calling the subunit runner with the list command and capture stdout from process and parse that sububit stream to get the test ids. However, this was not strictly necessary as we're not doing anything in parallel, so we should be able to just call the subunit_runner directly inline and use an in memory buffer instead of stdout. This has the advantage of not interfering with sys.stdout, in the previous method if anything besides the subunit_runner was printing to stdout it would cause a parser error because of the non-subunit data mixed into the stream.
mtreinish
changed the title
|
This is still failing some tests, it looks like there is an issue when calling from a function with the import paths that we'll need to debug first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the usage of subprocess from the discovery/list test
phase in TestProcessor. Previously to get a list of tests from discovery
we would subprocess out to a new python interpreter calling the subunit
runner with the list command and capture stdout from process and parse
that sububit stream to get the test ids. However, this was not strictly
necessary as we're not doing anything in parallel, so we should be able
to just call the subunit_runner directly inline and use an in memory
buffer instead of stdout. This has the advantage of not interfering
with sys.stdout, in the previous method if anything besides the
subunit_runner was printing to stdout it would cause a parser error
because of the non-subunit data mixed into the stream.