Fix parser to reject incomplete reductions like ([, ({, (( #3139
Conversation
|
Can you give an example where |
|
... and where is a problem with the comma? |
src/tests/syntax_errors.pl
Outdated
| % Test that (( produces syntax error | ||
| test("(( should produce syntax_error", ( | ||
| catch( | ||
| (read_from_chars("((}.", _), false), |
There was a problem hiding this comment.
This example is not very convincing, since it always produced a syntax error (for whatever reason). So what is its point?
There was a problem hiding this comment.
multitasking error, stand by
There was a problem hiding this comment.
(... divergent branches, git status says I should do git pull)
There was a problem hiding this comment.
perhaps looking at the combined testing branch would be better:
https://github.com/jjtolton/scryer-prolog/tree/combined-testing
That has digits, this, and double bars
There was a problem hiding this comment.
(... divergent branches,
git statussays I should dogit pull)
Forget it, your combined branch is it!
src/tests/syntax_errors.pl
Outdated
| % Test that {( produces syntax error (already tested in ISO conformity) | ||
| test("{( should produce syntax_error", ( | ||
| catch( | ||
| (read_from_chars("{(}.", _), false), |
Fixes mthom#3138 The parser was incorrectly accepting expressions like ([ and ({ as valid syntax, parsing them as atoms instead of rejecting them as incomplete reductions. This fix adds checks in reduce_brackets() to reject when an opening parenthesis is followed by: - Opening bracket [ - Opening curly brace { Note: (, and (( were already correctly rejected by existing checks. This brings the behavior in line with how curly braces work, where {[ and {( correctly produce syntax errors. Added tests in src/tests/syntax_errors.pl to verify the fix and prevent regressions.
Reject invalid bracket combinations like ([) and ({) where
parentheses would incorrectly close list or curly brackets.
Related: PR mthom#3139, Issue #3 (bracket mismatch detection)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
2 participants
Closes: #3138