Accept None as TFTP root #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If None is given as tftproot upon tftpServer creation, the server always forwards the file returned by its dyn_file_func method. This is useful if full access to the file system should not be granted for the tftp client. The client can still get files, but is restricted as appropriate by the dyn_file_func method. If tftproot and dyn_fil_func are both None, a exception is raised
|
Mostly looks fine, although https://stackoverflow.com/questions/14247373/python-none-comparison-should-i-use-is-or and we should have tests to exercise this. |
|
Hi @msoulier, are you still maintaining this repository? I'd like to see this change merged, so if you're still working on this, shall I fix up this patch and create a new PR? |
|
@twvd Well I did ask a question that was not responded to, so I'm not sure why you're asking if I'm still working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased my former pull request off of the current master branch.
If None is given as tftproot upon tftpServer creation, the server always
forwards the file returned by its dyn_file_func method. This is useful if full
access to the file system should not be granted for the tftp client. The
client can still get files, but is restricted as appropriate by the
dyn_file_func method.
If tftproot and dyn_file_func are both None, an exception is raised.