Skip to content

Conversation

@xc-racer99
Copy link

The Palm phone bootloader has a few quirks, so need to add some code to set the OS version and patch level in the generated lk2nd image. Then add support for the device itself. It only has a single power button, so use the short/long press control for it.

Some bootloaders check that there is valid in the OS version and/or
patch level fields of the Android boot.img.  Add the ability to specify
them.
Copy link
Member

@TravMurav TravMurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Sorry for the delay. The changes look good to me apart from one comment below

model = "Palm Phone (pepito)";
compatible = "palm,pepito";

lk2nd,dtb-files = "qcom,msm8940-mtp", "qcom,msm8940", "qcom,mtp";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should define a dtb filename for this device, not a list of compatibles (especially downstream ones), which would be used for booting a generic linux image with extlinux.conf. If you have some work to run linux on this device, please put the name of your dtb here

Additionally `lk2nd,dtb-files` property can be present with a list of possible
device-tree names for this device. Don't add `qcom/` or `qcom-` prefix and `.dtb`
suffix to the values since lk2nd will add them as necessary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I misinterpreted what this line was for - thanks! I haven't (yet) had a chance to do a mainline linux port. Since that's the case, should the property just be deleted?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you believe you know what the dtb name should be, you can add it, and we can fix it later if upstream wants the filename changed. Otherwise some devices define it as a comment with a best guess (can grep for FIXME in the dts dir)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants