This repository was archived by the owner on Apr 16, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
update to Swift 5, add new HealthKit parameters #7
Open
mkhoshpour
wants to merge
19
commits into
mseemann:master
Choose a base branch
from
mkhoshpour:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate, walking heart rate) added apple stand hours added heart rate context to metadata
Anyway to get the compatible code with swift 5? |
check my fork please: |
awesome! Ill check it right now :D |
giving me error finding a info.plist :( /healthkit-sample-generator-master/Example/Pods/Target Support Files/HealthKitSampleGenerator/ResourceBundle-HealthKitSampleGenerator-HealthKitSampleGenerator-Info.plist |
@Lukas182 fixed, please check again |
Thanks! @mkhoshpour :D! |
Hello mate, could you merge to master? once approved |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, please review my PR
I have updated code for swift 5.0 and added new HK parameters.
The repo is compatible with Xcode 11 now.
Thanks