Skip to content

Conversation

@danilobuerger
Copy link
Contributor

Blurhash imports RCTImageLoader which is part of React-RCTImage. This fixes failing builds with use_frameworks! (cocoapods) enabled.

Blurhash imports RCTImageLoader which is part of React-RCTImage. This fixes failing builds with use_frameworks! (cocoapods) enabled.
@danilobuerger
Copy link
Contributor Author

This doesn't seem to work once use_frameworks! is disabled:

[!] The following Swift pods cannot yet be integrated as static libraries:

The Swift pod `react-native-blurhash` depends upon `React-RCTImage`, which does not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies.

need to investigate more.

@danilobuerger danilobuerger marked this pull request as draft March 8, 2022 09:27
@mrousavy
Copy link
Owner

mrousavy commented Mar 9, 2022

Ah yeah, I remember having this issue a while back. :/

@mrousavy
Copy link
Owner

mrousavy commented Mar 9, 2022

I'll publish a release with your other change for now, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants