Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion reactive-banana-gi-gtk/reactive-banana-gi-gtk.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ library
build-depends: base >= 4.7 && < 5,
reactive-banana < 1.3
, gi-gtk >= 3.0.1.1 && < 5.0
, haskell-gi-base >= 0.20 && < 0.26
, haskell-gi-base >= 0.22 && < 0.26
, transformers >= 0.5.2.0 && < 0.6
, text >= 1.2.2.1 && < 1.3
default-language: Haskell2010
Expand Down
17 changes: 8 additions & 9 deletions reactive-banana-gi-gtk/src/Reactive/Banana/GI/Gtk.hs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import Reactive.Banana.Frameworks

import Data.Typeable
import Control.Exception
import Control.Monad.IO.Class
import Data.Maybe (fromJust)
import qualified Data.Text as T
import Data.Text (Text)
Expand All @@ -48,6 +47,7 @@ import Data.GI.Base.Overloading
import Data.GI.Base.Signals
( SignalInfo(..)
, GObjectNotifySignalInfo(..)
, disconnectSignalHandler
)
import GI.Gtk
( GObject
Expand Down Expand Up @@ -91,11 +91,11 @@ signalAddHandler
-> SignalProxy self info
-> ((a -> IO b) -> HaskellCallbackType info)
-> b
-> IO (AddHandler a)
signalAddHandler self signal f b = do
(addHandler, fire) <- newAddHandler
on self signal (f $ \x -> fire x >> return b)
return addHandler
-> AddHandler a
signalAddHandler self signal f b =
AddHandler $ \fire ->
on self signal (f $ \x -> fire x >> return b) >>=
pure . disconnectSignalHandler self

-- | Create an 'Reactive.Banana.Event' from
-- a 'Data.GI.Base.Signals.SignalProxy'. For making signalE# functions.
Expand All @@ -111,9 +111,8 @@ signalEN
-> ((a -> IO b) -> HaskellCallbackType info)
-> b
-> MomentIO (Event a)
signalEN self signal f b = do
addHandler <- liftIO $ signalAddHandler self signal f b
fromAddHandler addHandler
signalEN self signal f b =
fromAddHandler $ signalAddHandler self signal f b

-- | Get an 'Reactive.Banana.Event' from
-- a 'Data.GI.Base.Signals.SignalProxy' that produces nothing.
Expand Down