-
Notifications
You must be signed in to change notification settings - Fork 2
Add LAMMPS testing #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on this! Just a few comments from me and a suggestion on how to address the topology tests.
…icles are in box.
@mayukh33, could you review the changes to |
Looks good to me! |
@mphoward, this is ready for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This generally looks really good. Please address my comments and let me know if you have any questions.
@mphoward, this should have all your comments addressed and be ready for you to take another look at! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice work! I have only a couple more things, then this is ready to merge.
@mphoward, this should be good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is a much-needed addition.
No description provided.