Skip to content

Add LAMMPS testing #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
May 28, 2025
Merged

Add LAMMPS testing #78

merged 34 commits into from
May 28, 2025

Conversation

mayukh33
Copy link
Contributor

No description provided.

Copy link
Contributor

@clpetix clpetix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this! Just a few comments from me and a suggestion on how to address the topology tests.

@clpetix
Copy link
Contributor

clpetix commented May 20, 2025

@mayukh33, could you review the changes to dump.py?

@mayukh33
Copy link
Contributor Author

@mayukh33, could you review the changes to dump.py?

Looks good to me!

@clpetix
Copy link
Contributor

clpetix commented May 22, 2025

@mphoward, this is ready for your review!

Copy link
Contributor

@mphoward mphoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This generally looks really good. Please address my comments and let me know if you have any questions.

@clpetix
Copy link
Contributor

clpetix commented May 27, 2025

@mphoward, this should have all your comments addressed and be ready for you to take another look at!

@mphoward mphoward self-requested a review May 27, 2025 21:29
Copy link
Contributor

@mphoward mphoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice work! I have only a couple more things, then this is ready to merge.

@clpetix
Copy link
Contributor

clpetix commented May 28, 2025

@mphoward, this should be good to go!

Copy link
Contributor

@mphoward mphoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is a much-needed addition.

@mphoward mphoward linked an issue May 28, 2025 that may be closed by this pull request
@mphoward mphoward merged commit 511c943 into main May 28, 2025
14 checks passed
@mphoward mphoward deleted the feature/lammps-testing branch May 28, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test lammpsio with LAMMPS
4 participants