chore: migrate reactstrap to react bootstrap #8897
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this has a failing test that seems to be something new. here are docs to run the tests locally: |
camd
force-pushed
the
camd/migrate-reactstrap-to-react-bootstrap
branch
10 times, most recently
from
d68f38c to
9cfda9f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8897 +/- ##
==========================================
- Coverage 77.67% 77.66% -0.02%
==========================================
Files 577 577
Lines 29044 29066 +22
Branches 3573 3549 -24
==========================================
+ Hits 22561 22574 +13
- Misses 6318 6332 +14
+ Partials 165 160 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmaher
approved these changes
Sep 5, 2025
| @@ -578,3 +578,15 @@ | |||
| height: 100%; | |||
| background-color: rgba(20, 19, 19, 0.3); | |||
| } | |||
|
|
|||
| .visually-hidden { | |||
There was a problem hiding this comment.
- All these
!importantrules feel like a hack - can they be avoided? - Is there a caller for this class? Neither in pre-existing nor in new code I can find one.
camd
force-pushed
the
camd/migrate-reactstrap-to-react-bootstrap
branch
from
9cfda9f to
1737df9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This made a lot of changes. Thankfully, there is a very similar, modern package called
react-bootstrapthat I was able to upgrade to. This looks to be working quite well. But I am not able to log into Push Health to check that yet.