feat(payments-api): add Stripe webhook handler #19598
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StaberindeZA
force-pushed
the
pay-3292-api-stripe-webhooks
branch
2 times, most recently
from
20843e2 to
ff811a5
Compare
Because: - The payments-api service needs to be able to processes Stripe webhooks This commit: - Adds Controller, StripeWebhookService and related modules to payments-api Closes #PAY-3292
StaberindeZA
force-pushed
the
pay-3292-api-stripe-webhooks
branch
from
ff811a5 to
601db2f
Compare
julianpoy
reviewed
Oct 28, 2025
Comment on lines
+32
to
+42
| const eventAlreadyProcessed = await this.stripeEventManager.isProcessed( | ||
| webhookEventResponse.event.id | ||
| ); | ||
|
|
||
| if (eventAlreadyProcessed) { | ||
| return {}; | ||
| } | ||
|
|
||
| await this.dispatchEventToHandler(webhookEventResponse); | ||
|
|
||
| await this.stripeEventManager.markAsProcessed(webhookEventResponse.event); |
There was a problem hiding this comment.
[non-blocking] Looks like this allows two requests filed in parallel and does not de-dupe. Not the biggest deal, but I think this would need to be solved with two fields lastAttemptedAt: date and processed: true|false on the webhook event.
julianpoy
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #PAY-3292
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.