fix(payments-next): [SP3] Postal Code field on country selector modal allows unlimited characters #19545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| })); | ||
| }} | ||
| onInvalid={(e: React.FormEvent<HTMLInputElement>) => { | ||
| if (e.currentTarget.validity.patternMismatch) { |
There was a problem hiding this comment.
I believe that many of these subfields can be undefined. Can you update this with optional chaining? e.g. e?.currentTarget?.{...}
… allows unlimited charaters Because: * The Postal Code field allows a large number of characters. This commit: * Makes Postal Code field limited to a predefined number of characters. Closes #PAY-3229
elizabeth-ilina
force-pushed
the
PAY-3229-postal-code-allows-unlimited-charaters
branch
from
c1c95ad to
d26ffb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #PAY-3229
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.