Skip to content

Conversation

@janbrasna
Copy link
Collaborator

One-line summary

Reinstates some useful tests, and expands the list for a11y coverage.

Significant changes and points to review

There are axe test failures on some of the newly added pages. I'll add the reports for more info. This can either land to deliberately start failing the tests until fixed, or can be added with the exclusions enumerated for now, or can wait to merge until the a11y issues reported are fixed.

Issue / Bugzilla link

#16405

Testing

npm run a11y-tests

test-results-a11y.zip

Comment on lines -11 to 14
* URL paths for inclusion in page-level a11y scans.
* Pages will be scanned at both desktop and mobile resolutions.
* Different set of pages will be scanned at desktop and mobile resolutions.
*/
const desktopTestURLs = [
'/en-US/',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW I've changed the wording because I wasn't entirely sure what list would be used for what, so I hopefully got it right this way. Feel free to suggest any improvements if I'm not making it clear, or getting it completely wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant