Skip to content

iMDP: allow reachRewards from outside & limited policy extraction support #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

iMDP: allow reachRewards from outside & limited policy extraction support #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9487473
support reward computations and policy extraction (when endcomponents…
sjunges Jul 26, 2025
e2fcf4f
format fix
sjunges Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/storm/modelchecker/prctl/SparseMdpPrctlModelChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ bool SparseMdpPrctlModelChecker<SparseMdpModelType>::canHandleStatic(CheckTask<s
if (formula.isInFragment(storm::logic::propositional())) {
return true;
}
if (formula.isInFragment(storm::logic::reachability())) {
if (formula.isInFragment(storm::logic::reachability().setReachabilityRewardFormulasAllowed(true).setRewardOperatorsAllowed(true))) {
return true;
}
} else {
Expand Down
12 changes: 2 additions & 10 deletions src/storm/modelchecker/prctl/helper/SparseMdpPrctlHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1332,11 +1332,7 @@ MDPSparseModelCheckingHelperReturnType<SolutionType> SparseMdpPrctlHelper<ValueT
// If requested, we will produce a scheduler.
std::unique_ptr<storm::storage::Scheduler<SolutionType>> scheduler;
if (produceScheduler) {
if constexpr (std::is_same_v<ValueType, storm::Interval>) {
STORM_LOG_THROW(false, storm::exceptions::NotImplementedException, "We do not support producing schedulers in this function with interval models.");
} else {
scheduler = std::make_unique<storm::storage::Scheduler<SolutionType>>(transitionMatrix.getRowGroupCount());
}
scheduler = std::make_unique<storm::storage::Scheduler<SolutionType>>(transitionMatrix.getRowGroupCount());
}

// Check if the values of the maybe states are relevant for the SolveGoal
Expand Down Expand Up @@ -1433,11 +1429,7 @@ MDPSparseModelCheckingHelperReturnType<SolutionType> SparseMdpPrctlHelper<ValueT
STORM_LOG_ASSERT((!produceScheduler && !scheduler) || scheduler->isDeterministicScheduler(), "Expected a deterministic scheduler");
STORM_LOG_ASSERT((!produceScheduler && !scheduler) || scheduler->isMemorylessScheduler(), "Expected a memoryless scheduler");

if constexpr (std::is_same_v<ValueType, storm::Interval>) {
return MDPSparseModelCheckingHelperReturnType<SolutionType>(std::move(result));
} else {
return MDPSparseModelCheckingHelperReturnType<SolutionType>(std::move(result), std::move(scheduler));
}
return MDPSparseModelCheckingHelperReturnType<SolutionType>(std::move(result), std::move(scheduler));
}

template<typename ValueType, typename SolutionType>
Expand Down
Loading