-
Notifications
You must be signed in to change notification settings - Fork 6
E2e booking & cancelation #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Switched to environment variables from process.env We now need a way to communicate the simulation time set on the server side to the client. May be this can be done using Svelte's render? |
return second * SECOND; | ||
} | ||
|
||
export function nowOrSimulationTime() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this function be in the lib/server
folder? It can't be used on the client
In case this function is only used in SvelteKit, it could also use $env
- if it's used in Playwright too then not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should probably be in lib/server
then since it is indeed only used on the server.
For the booking e2e test, we want to set a specific simulation time so I guess it also has to be used in Playwright.
#228 adds simulation time
playwright test cases currently not working: