Skip to content

Conversation

@Rakshithasai123
Copy link

@Rakshithasai123 Rakshithasai123 commented Nov 12, 2025

RCF-183

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced error messages across multiple languages (Arabic, English, French, Hindi, Kannada, Tamil) when device registration is incomplete. Messages now provide clearer guidance directing users to contact their administrator for assistance.

@coderabbitai
Copy link

coderabbitai bot commented Nov 12, 2025

Walkthrough

Six localization resource files were updated to provide more descriptive and user-friendly error messages. The REG_MACHINE_NOT_FOUND error message was expanded across all supported languages (Arabic, English, French, Hindi, Kannada, and Tamil) to indicate the device has not been onboarded yet and direct users to contact their administrator.

Changes

Cohort / File(s) Summary
Localization error messages
assets/l10n/app_ar.arb, assets/l10n/app_en.arb, assets/l10n/app_fr.arb, assets/l10n/app_hi.arb, assets/l10n/app_kn.arb, assets/l10n/app_ta.arb
Updated REG_MACHINE_NOT_FOUND error message in the errors string resource from short text (e.g., "Machine not found!") to verbose, user-facing message indicating device onboarding status and suggesting admin contact in each respective language. Added or updated @errors metadata block with "messages" placeholder of type String.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • All changes are homogeneous localization string and metadata updates following the same pattern across six files
  • No logic, control flow, or behavioral modifications
  • Simple text replacements and metadata additions are low-risk

Poem

🐰 Hops and cheers for clearer words,
Six tongues now speak with care unburred,
"Contact admin," the message stays,
Through Hindi, French, and Arabic ways!
Device onboarded? Now we say,
"Not yet, friend—help's just a hop away!" ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly summarizes the main change: updating error messages across multiple localization files to display an appropriate, user-friendly message when a device is not onboarded.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b77ee5f and 5daf4cb.

📒 Files selected for processing (6)
  • assets/l10n/app_ar.arb (1 hunks)
  • assets/l10n/app_en.arb (1 hunks)
  • assets/l10n/app_fr.arb (1 hunks)
  • assets/l10n/app_hi.arb (1 hunks)
  • assets/l10n/app_kn.arb (1 hunks)
  • assets/l10n/app_ta.arb (1 hunks)
🔇 Additional comments (6)
assets/l10n/app_fr.arb (1)

308-308: LGTM! French error message updated appropriately.

The updated message provides clear guidance to users, instructing them to contact their administrator for assistance with device onboarding.

assets/l10n/app_hi.arb (1)

308-308: LGTM! Hindi error message updated successfully.

The error message now provides actionable guidance for users experiencing device onboarding issues.

assets/l10n/app_kn.arb (1)

308-308: LGTM! Kannada error message updated appropriately.

The updated message provides clear instructions for users to contact their administrator for device onboarding assistance.

assets/l10n/app_ar.arb (1)

308-308: LGTM! Arabic error message updated successfully.

The error message now provides helpful guidance, directing users to contact their administrator for onboarding support.

assets/l10n/app_en.arb (1)

308-308: LGTM! English error message significantly improved.

The updated error message is clear, professional, and actionable. It properly explains that the device hasn't been onboarded yet and directs users to contact their administrator for assistance, which is much better than the previous generic "Machine not found!" message.

assets/l10n/app_ta.arb (1)

317-317: Standalone machine_not_found key is not referenced in active code—recommend removal or clarification of retention purpose.

Verification shows the old "machine_not_found" key at line 39 is orphaned: it has no references in Dart code. The actual error flow uses REG_MACHINE_NOT_FOUND (set by Java backend in AuthenticationApi.java), which maps to the improved ICU selector message in the "errors" key at line 317.

Since the standalone key is unused, consider:

  • Remove it if it's truly legacy code, or
  • Document why it's retained if needed for backward compatibility

The primary localization update (line 317) is correct and complete.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant