Inform the user that a binding was redefined #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dead code
keddelzz
changed the title
keddelzz
approved these changes
Jun 14, 2017
rexim
commented
Jun 14, 2017
| // 2. REPL message for the user | ||
| // | ||
| // We need to separate those meanings. The proposed idea is to | ||
| // attach some kind of side effect to ReplContext and use |
rexim
commented
Jun 14, 2017
| if (!context.contains(binding)) { | ||
| None | ||
| } else { | ||
| Some(s"${binding.variable} was redefined") |
There was a problem hiding this comment.
*Warning: ${binding.variable} was redefined
ForNeVeR
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #197