Skip to content

Bump selenium image to version 4 #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

Conversation

kabalin
Copy link
Member

@kabalin kabalin commented May 29, 2025

This aligns default Selenium version with moodle-docker.

Also patchset adds MOODLE_500_STABLE to GHA/Travis tests to cover latest release.

kabalin added 2 commits May 29, 2025 20:31
This will align default Selenium version with moodle-docker.

Fixes moodlehq#352
@kabalin kabalin linked an issue May 29, 2025 that may be closed by this pull request
@kabalin kabalin requested a review from stronk7 May 29, 2025 19:57
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.31%. Comparing base (d3e0af6) to head (229b485).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #354   +/-   ##
=========================================
  Coverage     88.31%   88.31%           
+ Complexity      762      761    -1     
=========================================
  Files            77       77           
  Lines          2344     2344           
=========================================
  Hits           2070     2070           
  Misses          274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrewnicols
Copy link
Contributor

This currently fails against Travis @kabalin.

I'm increasingly of the opinion that we should drop support for Travis. Do we have any evidence that people actually still use it?

@kabalin
Copy link
Member Author

kabalin commented May 30, 2025

This currently fails against Travis @kabalin.

I'll merge with unmet requirements (looks like zlib extension is missing in Travis). Thanks for review!

I'm increasingly of the opinion that we should drop support for Travis. Do we have any evidence that people actually still use it?

I agree. No idea if anyone uses it, I guess ticket #351 could make it evident.

@kabalin kabalin merged commit d5e4885 into moodlehq:main May 30, 2025
30 of 31 checks passed
@kabalin kabalin deleted the bump-selenium-image branch May 30, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BehatCommand default selenium images outdated
2 participants