-
Notifications
You must be signed in to change notification settings - Fork 5
Add invite route. #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically the API user needs to be a member of the room to do the invite, but I don't think that we currently have them in the virtual room.
This is something that we may need to add in future.
This change is mostly good otherwise aside from some coding style issues. The main thing that is missing is that it doesn't actually do what it needs to do - that is it does not invite the user into the room!
Also can you please squash the commits. We don't need to break things apart - it serves no purpose or benefit, and can be confusing when tracking bugs. |
@andrewnicols Thanks for reviewing this so quickly. I was not expecting this as there are very few guidelines for contributors. I also did not know what coding style to use, I could not find it explicitly stated in the repository. Adding that would help, and maybe I would have started contributing earlier! :) I agree with your changes and will try to merge them in a minute. And of course I can squash them right away, unless you prefer to do a squash on the merge. |
6a2be28
to
7cb3bf7
Compare
6a2be28
to
b2a655c
Compare
Co-authored-by: Andrew Lyons <[email protected]> Actually store the status of the invited room member.
b2a655c
to
dca9677
Compare
Add
/_matrix/client/r0/rooms/{roomId}/invite
route.See https://spec.matrix.org/legacy/r0.0.0/client_server.html#post-matrix-client-r0-rooms-roomid-invite.
Related to: https://tracker.moodle.org/browse/MDL-84293