Skip to content

Conversation

@papafe
Copy link
Contributor

@papafe papafe commented Sep 23, 2025

C# driver implementation POC: mongodb/mongo-csharp-driver#1777

TODO:

  • Update changelog.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, and sharded
    clusters).
  • Add unified tests.
  • Add prose test for validation of input.
  • Add information about the new getSnapshotTime operation (for unified tests).
  • Add information about the new snapshotTime parameter of sessionOptions and that it must be retrieved from the entity map (for unified tests).
  • Check that re-doing the query operation is best course of action for unified tests to verify that the snapshotTime does not get modified again.

@papafe papafe marked this pull request as ready for review September 29, 2025 15:17
@papafe papafe requested a review from a team as a code owner September 29, 2025 15:17
@papafe papafe requested review from sanych-sun and removed request for a team September 29, 2025 15:17
@papafe papafe changed the title [WIP] DRIVERS-2782 Expose snapshotTime DRIVERS-2782: Expose snapshotTime Sep 29, 2025
@sanych-sun sanych-sun requested a review from qingyang-hu October 2, 2025 18:21
@papafe papafe requested a review from sanych-sun October 3, 2025 08:49
Copy link
Contributor

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@papafe papafe requested a review from a team as a code owner October 15, 2025 18:22
@papafe papafe requested review from alcaeus and sanych-sun and removed request for a team October 15, 2025 18:22
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the unified test format LGTM. Since we don't add operations to the schema, the unified test format does not get a version bump. Since this effectively prevents targeting a schema version in tests, please make sure to call out the requirement to implement getSnapshotTime in test runners in the ticket's downstream instructions.

Copy link
Member

@sanych-sun sanych-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@papafe papafe merged commit 03795d2 into mongodb:master Oct 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants