-
Notifications
You must be signed in to change notification settings - Fork 246
DRIVERS-2782: Expose snapshotTime #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
qingyang-hu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
alcaeus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to the unified test format LGTM. Since we don't add operations to the schema, the unified test format does not get a version bump. Since this effectively prevents targeting a schema version in tests, please make sure to call out the requirement to implement getSnapshotTime in test runners in the ticket's downstream instructions.
sanych-sun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
C# driver implementation POC: mongodb/mongo-csharp-driver#1777
TODO:
clusters).
getSnapshotTimeoperation (for unified tests).snapshotTimeparameter ofsessionOptionsand that it must be retrieved from the entity map (for unified tests).