Skip to content

task: delete unused store methods and mocks #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

task: delete unused store methods and mocks #3859

merged 1 commit into from
Apr 29, 2025

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Apr 29, 2025

As part of #3850 I identified a couple of methods that are unused and we should delete

@gssbzn gssbzn marked this pull request as ready for review April 29, 2025 08:35
@gssbzn gssbzn requested a review from a team as a code owner April 29, 2025 08:35
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report 📈

Branch Commit Coverage
master c2d556c 37.8%
unused-stores 0b19b0c 37.9%
Difference .1%

cveticm
cveticm approved these changes Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit 6bb1fc3 into master Apr 29, 2025
23 of 24 checks passed
@gssbzn gssbzn deleted the unused-stores branch April 29, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cveticm cveticm cveticm approved these changes

Assignees
No one assigned
Labels
atlascli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gssbzn @cveticm