Skip to content

PYTHON-5344 and PYTHON-5403 Allow Instantiated MongoClients to Send Client Metadata On-Demand #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

sleepyStick
Copy link
Contributor

@sleepyStick sleepyStick commented Jun 2, 2025

https://jira.mongodb.org/browse/PYTHON-5344
https://jira.mongodb.org/browse/PYTHON-5403 (ticket for async tests)

Notes:

  • I used mockupDB to capture the metadata that the client sends in the handshake
  • i put the tests in the normal tests folder (as opposed to the test/mockupdb) to utilize synchro for the async -> sync tests.

@sleepyStick sleepyStick marked this pull request as ready for review June 18, 2025 00:18
@sleepyStick sleepyStick changed the title PYTHON-5344 Allow Instantiated MongoClients to Send Client Metadata On-Demand PYTHON-5344 and PYTHON5403 Allow Instantiated MongoClients to Send Client Metadata On-Demand Jun 18, 2025
@sleepyStick sleepyStick changed the title PYTHON-5344 and PYTHON5403 Allow Instantiated MongoClients to Send Client Metadata On-Demand PYTHON-5344 and PYTHON-5403 Allow Instantiated MongoClients to Send Client Metadata On-Demand Jun 18, 2025
@sleepyStick sleepyStick requested a review from blink1073 June 18, 2025 16:33
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants