Skip to content

Conversation

bucaojit
Copy link
Member

@bucaojit bucaojit commented Aug 23, 2025

Adding support to pass in full PEM contents into password field. This will help for adding X509 support for Tableau Server, which is planned to be tested in SQL-2924.

If the PEM Path is set it will take precedence. Otherwise attempt to use the password property as PEM contents.

I verified that it connects via Tableau Desktop using both the unencrypted (raw PEM contents) and encrypted (passing in JSON with pem and passphrase keys).

@bucaojit bucaojit requested a review from a team as a code owner August 23, 2025 00:18
Copy link
Collaborator

@mattChiaravalloti mattChiaravalloti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice so far! Should just need one round of review and then we'll be good to go 👍

Copy link
Collaborator

@mattChiaravalloti mattChiaravalloti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

Copy link
Collaborator

@pmeredit pmeredit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants