-
Notifications
You must be signed in to change notification settings - Fork 42
SQL-2919: Support passing in X509 PEM contents as password #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice so far! Should just need one round of review and then we'll be good to go 👍
src/integration-test/java/com/mongodb/jdbc/integration/AuthX509IntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/mongodb/jdbc/utils/X509AuthenticationTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew Chiaravalloti <[email protected]>
Co-authored-by: Matthew Chiaravalloti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding support to pass in full PEM contents into password field. This will help for adding X509 support for Tableau Server, which is planned to be tested in SQL-2924.
If the PEM Path is set it will take precedence. Otherwise attempt to use the
password
property as PEM contents.I verified that it connects via Tableau Desktop using both the unencrypted (raw PEM contents) and encrypted (passing in JSON with
pem
andpassphrase
keys).