GODRIVER-3419 Use a semaphore to limit concurrent conn creation #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change ReportNo changes found! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3419
Summary
This PR refactors the connection pool to eliminate the persistent maxConnection goroutines spawns at pool construction. Here we adopt a more lightweight, on-demand model inspired by @matthewdale's POC c26a3cb. Each new goroutine is responsible for creating exactly one connection and then terminates immediately.
Background & Motivation
While so-far not reproducible locally, the "spawn-and-done" approach suggested by this PR intends to avoid any long-term memory allocation patterns causing the GC to thrash. See ticket for more information.