Skip to content

REP-6088 Fix display of verification summary #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

FGasper
Copy link
Collaborator

@FGasper FGasper commented Jun 12, 2025

PR #117 introduced some bugs in the verification summary logging. This addresses the following:

  • Mismatches were previously shown in an indeterminate order. Now they’re consistently sorted by the mismatched documents’ _id.
  • Documents with missing fields were being logged as entirely missing. That logic is corrected here.
  • The table of missing/changed documents previously iterated through the _ids persisted in the task rather than the actual missing/changed documents. Thus, if there were only a handful of missing documents in a recheck task that contained thousands of document IDs, all of that task’s document IDs would be logged as missing. This was an oversight from PR REP-6088 Tolerate high numbers of mismatches #117, which should have updated the logic to build that table as it migrated that for the mismatched-documents table. This changeset does the necessary update.

Additional changes here:

  • build.sh now logs the git commit & time that it’s building into the binary.
  • The compareOneDocument() method is moved to compare.go, which more sensible since that’s where it’s called.

@FGasper FGasper changed the title Fix display of verification summary REP-6088 Fix display of verification summary Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant