get all tool data #121
Merged
get all tool data #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laviomri
reviewed
Oct 28, 2025
Comment on lines
+7
to
+9
| "types": "./dist/esm/mcp/index.d.ts", | ||
| "import": "./dist/esm/mcp/index.js", | ||
| "require": "./dist/cjs/mcp/index.js", | ||
| "types": "./dist/esm/mcp/index.d.ts" | ||
| "require": "./dist/cjs/mcp/index.js" |
There was a problem hiding this comment.
what changed? the order? does it even matter?
There was a problem hiding this comment.
Seems this is the recommended way, no harm :)
laviomri
reviewed
Oct 28, 2025
| const manageTool = new ManageToolsTool(); | ||
| manageTool.setToolkitManager(this.dynamicToolManager); | ||
| this.registerSingleTool(manageTool as Tool<any, any>); | ||
| this.managementTool = manageTool as Tool<any, any>; |
There was a problem hiding this comment.
this casting is a bit smelly, but not urgent for now :)
laviomri
reviewed
Oct 28, 2025
| const mcpTool = this.registerTool( | ||
| tool.name, | ||
| { | ||
| ...tool, |
laviomri
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.