add object storage #76
Open
+823
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maorb-dev
reviewed
Jul 20, 2025
lib/minimal-package.ts
Outdated
| @@ -1 +1 @@ | |||
| export default { name: '@mondaycom/apps-sdk', version: '3.2.1' }; | |||
| export default { name: '@mondaycom/apps-sdk', version: '3.3.0-beta.3' }; | |||
There was a problem hiding this comment.
is this also needed here?
Comment on lines
148
to
169
| describe('listFiles', () => { | ||
| it('should list files with default options', async () => { | ||
| const result = await objectStorage.listFiles(); | ||
|
|
||
| expect(result.success).toBe(true); | ||
| expect(Array.isArray(result.files)).toBe(true); | ||
| }); | ||
|
|
||
| it('should list files with prefix filter', async () => { | ||
| const result = await objectStorage.listFiles({ prefix: 'test-' }); | ||
|
|
||
| expect(result.success).toBe(true); | ||
| expect(Array.isArray(result.files)).toBe(true); | ||
| }); | ||
|
|
||
| it('should list files with pagination', async () => { | ||
| const result = await objectStorage.listFiles({ maxResults: 10 }); | ||
|
|
||
| expect(result.success).toBe(true); | ||
| expect(Array.isArray(result.files)).toBe(true); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
all the tests here are the same, they last 2 cases dont actually check the prefix filter and the limit.
Comment on lines
1
to
51
| export type UploadFileOptions = { | ||
| contentType?: string; | ||
| metadata?: Record<string, string>; | ||
| } | ||
|
|
||
| export type UploadFileResponse = { | ||
| success: boolean; | ||
| fileName?: string; | ||
| fileUrl?: string; | ||
| error?: string; | ||
| } | ||
|
|
||
| export type DownloadFileResponse = { | ||
| success: boolean; | ||
| content?: Buffer; | ||
| contentType?: string; | ||
| error?: string; | ||
| } | ||
|
|
||
| export type DeleteFileResponse = { | ||
| success: boolean; | ||
| error?: string; | ||
| } | ||
|
|
||
| export type ListFilesOptions = { | ||
| prefix?: string; | ||
| maxResults?: number; | ||
| pageToken?: string; | ||
| } | ||
|
|
||
| export type FileInfo = { | ||
| name: string; | ||
| size: number; | ||
| contentType: string; | ||
| lastModified: Date; | ||
| etag: string; | ||
| metadata: Record<string, string>; | ||
| } | ||
|
|
||
| export type ListFilesResponse = { | ||
| success: boolean; | ||
| files?: Array<FileInfo>; | ||
| nextPageToken?: string; | ||
| error?: string; | ||
| } | ||
|
|
||
| export type GetFileInfoResponse = { | ||
| success: boolean; | ||
| fileInfo?: FileInfo; | ||
| error?: string; | ||
| } |
There was a problem hiding this comment.
let's extract { success; boolean, error?: string } into a shared base response
lib/object-storage/object-storage.ts
Outdated
Comment on lines
32
to
34
| /** | ||
| * Upload a file to the object storage bucket | ||
| */ |
There was a problem hiding this comment.
all of these method comments are redundant
lib/object-storage/object-storage.ts
Outdated
| */ | ||
| async getFileInfo(fileName: string): Promise<GetFileInfoResponse> { | ||
| try { | ||
| const bucket: Bucket = this.storage.bucket(this.bucketName); |
There was a problem hiding this comment.
this can be extracted to the class
Comment on lines
219
to
225
| } catch (error) { | ||
| const errorMessage = error instanceof Error ? error.message : String(error); | ||
| const errorObj = error instanceof Error ? error : new Error(String(error)); | ||
| logger.error('Failed to get file info:', { error: errorObj }); | ||
| return { | ||
| success: false, | ||
| error: `Failed to get file info: ${errorMessage}` |
There was a problem hiding this comment.
most of this can be extracted as well
maorb-dev
reviewed
Oct 21, 2025
| logger.error(`Failed to ${operation}:`, { error: errorObj }); | ||
| return { errorMessage, errorObj }; | ||
| } | ||
|
|
There was a problem hiding this comment.
@maorb-dev add another method that will provide the dev with a pre-signed url for uploading
There was a problem hiding this comment.
once added, also expose it with the mcode-sdk-api, simlar to this: https://github.com/DaPulse/mcode-sdk-api/pull/35/files
and also generate the python + PHP clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.