Skip to content

Conversation

opengeek
Copy link
Member

@opengeek opengeek commented Sep 24, 2025

What does it do?

Removes the JSONP callback support in modConnectorResponse.

Why is it needed?

This feature is potentially vulnerable to JSONP injection.

How to test

Make sure any callback parameters to a connector request are ignored.

Related issue(s)/PR(s)

#12420 and #13051 — vulnerability was reported privately.

@opengeek opengeek requested a review from Mark-H as a code owner September 24, 2025 15:52
@Mark-H
Copy link
Collaborator

Mark-H commented Sep 24, 2025

Referencing #12420 where this feature was added. I don't remember what I used it for, perhaps an early version of SiteDash before that added its own connector?

Copy link
Member

@garryn garryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants