Use BroadcastChannel API instead of window.opener
to communicate between auth popup & original window
#35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the usage of
window.opener
in communicating auth state from callback withBroadcastChannel API
Motivation and Context
This changes solves this issue: #33 where basically some auth providers could be preventing the
window.opener
value from being preserved, so the auth flow won't be able to communicate the success/failure at the end.How Has This Been Tested?
I tested it with our MCP server that had this problem, and the problem was solved.
Tested it with a couple of other MCP servers, and haven't seen any problems.
But feel free to test it in case I missed some edge case or there was a bug.
Breaking Changes
There shouldn't be any breaking changes.
Types of changes
Checklist