Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped the verl version to 0.5.0 with its respective docker image. Also, the pip command now builds the local clone (like is done in verl docs) instead of downloading a wheel.
The protobuf installed in the docker image is 5.29.5, which modal does not support, so the image also requires
.pip_install(f"protobuf==4.25.3")
. I thought I would mention it here, along with the stack trace, instead of including it in the commit.Type of Change
Monitoring Checklist
lambda-test: false
is provided in the example frontmatter and I have gotten approval from a maintainermodal run
, or an alternativecmd
is provided in the example frontmatter (e.g.cmd: ["modal", "serve"]
)cmd
with no arguments, or theargs
are provided in the example frontmatter (e.g.args: ["--prompt", "Formula for room temperature superconductor:"]
fastapi
to be installed locally (e.g. does not importrequests
ortorch
in the global scope or other code executed locally)Documentation Site Checklist
Build Stability
v1
, not a dynamic tag likelatest
python_version
for the base image, if it is used~=x.y.z
or==x.y
, or we expect this example to work across major versions of the dependency and are committed to maintenance across those versionsversion < 1
are pinned to patch version,==0.y.z