Skip to content

Conversation

hytopoulos
Copy link

@hytopoulos hytopoulos commented Aug 12, 2025

Bumped the verl version to 0.5.0 with its respective docker image. Also, the pip command now builds the local clone (like is done in verl docs) instead of downloading a wheel.

The protobuf installed in the docker image is 5.29.5, which modal does not support, so the image also requires .pip_install(f"protobuf==4.25.3"). I thought I would mention it here, along with the stack trace, instead of including it in the commit.

Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 187, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/usr/lib/python3.10/runpy.py", line 110, in _get_module_details
    __import__(pkg_name)
  File "/pkg/modal/__init__.py", line 12, in <module>
    from ._runtime.execution_context import current_function_call_id, current_input_id, interact, is_local
  File "/pkg/modal/_runtime/execution_context.py", line 6, in <module>
    from modal._utils.async_utils import synchronize_api
  File "/pkg/modal/_utils/async_utils.py", line 29, in <module>
    from .logger import logger
  File "/pkg/modal/_utils/logger.py", line 47, in <module>
    configure_logger(logger, log_level, log_format)
  File "/pkg/modal/_utils/logger.py", line 7, in configure_logger
    from modal.config import config
  File "/pkg/modal/config.py", line 94, in <module>
    from modal_proto import api_pb2
  File "/pkg/modal_proto/api_pb2.py", line 16, in <module>
    from modal_proto import options_pb2 as modal__proto_dot_options__pb2
  File "/pkg/modal_proto/options_pb2.py", line 29, in <module>
    google_dot_protobuf_dot_descriptor__pb2.FieldOptions.RegisterExtension(audit_target_attr)
AttributeError: type object 'FieldOptions' has no attribute 'RegisterExtension'

Type of Change

  • Example updates (Bug fixes, new features, etc.)

Monitoring Checklist

  • Example is configured for testing in the synthetic monitoring system, or lambda-test: false is provided in the example frontmatter and I have gotten approval from a maintainer
    • Example is tested by executing with modal run, or an alternative cmd is provided in the example frontmatter (e.g. cmd: ["modal", "serve"])
    • Example is tested by running the cmd with no arguments, or the args are provided in the example frontmatter (e.g. args: ["--prompt", "Formula for room temperature superconductor:"]
    • Example does not require third-party dependencies besides fastapi to be installed locally (e.g. does not import requests or torch in the global scope or other code executed locally)

Documentation Site Checklist

Build Stability

  • Example pins all dependencies in container images
    • Example pins container images to a stable tag like v1, not a dynamic tag like latest
    • Example specifies a python_version for the base image, if it is used
    • Example pins all dependencies to at least SemVer minor version, ~=x.y.z or ==x.y, or we expect this example to work across major versions of the dependency and are committed to maintenance across those versions
      • Example dependencies with version < 1 are pinned to patch version, ==0.y.z

@hytopoulos hytopoulos marked this pull request as ready for review August 12, 2025 01:20
@luiscape luiscape requested a review from advay-modal August 12, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant