Feature/Show groups list #45
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,133 @@ | ||
| package br.com.mob1st.bet.features.groups | ||
|
|
||
| import androidx.compose.foundation.layout.* | ||
| import androidx.compose.foundation.lazy.LazyColumn | ||
| import androidx.compose.foundation.lazy.itemsIndexed | ||
| import androidx.compose.material.icons.Icons | ||
| import androidx.compose.material.icons.filled.Person | ||
| import androidx.compose.material3.CircularProgressIndicator | ||
| import androidx.compose.material3.Icon | ||
| import androidx.compose.material3.MaterialTheme | ||
| import androidx.compose.material3.ProvideTextStyle | ||
| import androidx.compose.material3.Text | ||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.runtime.LaunchedEffect | ||
| import androidx.compose.runtime.getValue | ||
| import androidx.compose.ui.Alignment | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.res.stringResource | ||
| import androidx.lifecycle.compose.ExperimentalLifecycleComposeApi | ||
| import androidx.lifecycle.compose.collectAsStateWithLifecycle | ||
| import br.com.mob1st.bet.core.ui.compose.LocalLazyListState | ||
| import br.com.mob1st.bet.core.ui.compose.LocalSnackbarState | ||
| import br.com.mob1st.bet.core.ui.ds.molecule.AddButton | ||
| import br.com.mob1st.bet.core.ui.ds.molecule.RetrySnackbar | ||
| import br.com.mob1st.bet.core.ui.ds.organisms.FetchedCrossfade | ||
| import br.com.mob1st.bet.core.ui.ds.organisms.GroupRow | ||
| import br.com.mob1st.bet.core.ui.ds.page.DefaultErrorPage | ||
| import br.com.mob1st.bet.core.ui.ds.templates.InfoTemplate | ||
| import br.com.mob1st.bet.core.ui.state.AsyncState | ||
| import br.com.mob1st.bet.core.ui.state.SimpleMessage | ||
| import br.com.mob1st.bet.core.utils.extensions.ifNotEmpty | ||
|
|
||
| @OptIn(ExperimentalLifecycleComposeApi::class) | ||
| @Composable | ||
| fun GroupsTabScreen( | ||
| viewModel: GroupTabViewModel, | ||
| onNavigateToCreateGroups: () -> Unit, | ||
| onNavigateToGroupDetails: () -> Unit | ||
| ) { | ||
| val state by viewModel.uiState.collectAsStateWithLifecycle() | ||
| val listGroups = viewModel.groups | ||
|
|
||
| LaunchedEffect(key1 = true) { | ||
| listGroups.collect() { | ||
| viewModel.getGroups() | ||
| } | ||
| } | ||
|
|
||
| Column( | ||
| horizontalAlignment = Alignment.CenterHorizontally, | ||
| verticalArrangement = Arrangement.Top , | ||
| modifier = Modifier.fillMaxSize() | ||
| ) { | ||
| ProvideTextStyle(MaterialTheme.typography.headlineMedium){ | ||
| Text("Seus grupos") | ||
| } | ||
| AddButton(onNavigateToCreateGroups) | ||
|
|
||
| GroupsPage( | ||
| state = state, | ||
| onTryAgain = { viewModel.fromUi(GroupsUIEvent.TryAgain(it)) } , | ||
| onDismiss = { viewModel.messageShown(it) } | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| @Composable | ||
| fun GroupsPage( | ||
| state: AsyncState<GroupsListData>, | ||
| onTryAgain: (SimpleMessage) -> Unit, | ||
| onDismiss: (SimpleMessage) -> Unit | ||
| ) { | ||
| Box( | ||
| contentAlignment = Alignment.Center | ||
| ) { | ||
| FetchedCrossfade( | ||
| state = state, | ||
| emptyError = {_, message -> DefaultErrorPage(message, onTryAgain)}, | ||
| emptyLoading = { EmptyLoading() }, | ||
| empty = { GroupsEmptyData() }, | ||
| data = { | ||
| GroupsData( | ||
| state = it, | ||
| onTryAgain = onTryAgain, | ||
| onDismiss = onDismiss | ||
| ) | ||
| } | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| @Composable | ||
| fun GroupsData( | ||
| state: AsyncState<GroupsListData>, | ||
| onTryAgain: (SimpleMessage) -> Unit, | ||
| onDismiss: (SimpleMessage) -> Unit | ||
| ) { | ||
| state.messages.ifNotEmpty { | ||
| RetrySnackbar( | ||
| snackbarHostState = LocalSnackbarState.current, | ||
| message = stringResource(id = it.descriptionResId), | ||
| onDismiss = { onDismiss(it) }, | ||
| onRetry = { onTryAgain(it) } | ||
| ) | ||
| } | ||
| LazyColumn( | ||
| modifier = Modifier.fillMaxSize(), | ||
| state = LocalLazyListState.current | ||
| ) { | ||
| itemsIndexed( | ||
| state.data.groupList, | ||
| key = { _, item -> item.id }, | ||
| ) { _, item -> | ||
| GroupRow(groupName = item.name, currentMembersNumber = 4, maxMembers = 4) {} | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Composable | ||
| fun EmptyLoading() { | ||
| Box(modifier = Modifier.fillMaxSize(), contentAlignment = Alignment.Center) { | ||
| CircularProgressIndicator() | ||
| } | ||
| } | ||
|
|
||
| @Composable | ||
| fun GroupsEmptyData() { | ||
| InfoTemplate( | ||
| icon = { Icon(imageVector = Icons.Default.Person, contentDescription = "groups tab") }, | ||
| title = { Text("Sem grupos") }, | ||
| description = { Text("Tente criar ou entrar em algum grupo.") } | ||
| ) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| package br.com.mob1st.bet.features.groups | ||
|
|
||
| import br.com.mob1st.bet.core.ui.state.FetchedData | ||
| import br.com.mob1st.bet.core.ui.state.SimpleMessage | ||
| import br.com.mob1st.bet.core.ui.state.StateViewModel | ||
| import br.com.mob1st.bet.features.groups.domain.GroupEntry | ||
| import br.com.mob1st.bet.features.groups.domain.GroupRepository | ||
| import br.com.mob1st.bet.features.profile.domain.UserRepository | ||
| import kotlinx.coroutines.flow.MutableStateFlow | ||
| import kotlinx.coroutines.flow.StateFlow | ||
| import org.koin.android.annotation.KoinViewModel | ||
|
|
||
| data class GroupsListData( | ||
| val groupList: List<GroupEntry> = emptyList() | ||
| ) : FetchedData { | ||
| override fun hasData(): Boolean = groupList.isNotEmpty() | ||
| } | ||
|
|
||
| sealed class GroupsUIEvent { | ||
| data class TryAgain(val message: SimpleMessage) : GroupsUIEvent() | ||
| } | ||
|
|
||
| @KoinViewModel | ||
| class GroupTabViewModel( | ||
| private val repository: GroupRepository, | ||
| private val userRepository: UserRepository | ||
|
There was a problem hiding this comment. lá vem textão: Portanto, talvez seja melhor criar uma class UseCase, tipo GetGroupsUseCase, e fazer com que esse usecase use os repositórios pra implementar as regras de negócio. é um detalhe besta em um primeiro momento, mas essas pequenas decisões tem um peso grande conforme o projeto vai crescendo. There was a problem hiding this comment. Pode crer, faz sentido. Como essa tela não ia ter useCase por enquanto acabei fazendo tudo no viewModel mesmo, mas vou me atentar mais nisso nas próximas. |
||
| ) : StateViewModel<GroupsListData, GroupsUIEvent>(GroupsListData(), loading = false) { | ||
| override fun fromUi(uiEvent: GroupsUIEvent) { | ||
| when (uiEvent) { | ||
| is GroupsUIEvent.TryAgain -> tryAgain(uiEvent.message) | ||
| } | ||
| } | ||
|
|
||
| private val _groups = MutableStateFlow<List<GroupEntry>>(emptyList()) | ||
| val groups: StateFlow<List<GroupEntry>> = _groups | ||
|
|
||
| init { | ||
| getGroups() | ||
| } | ||
|
|
||
| private fun tryAgain(message: SimpleMessage) { | ||
| messageShown(message, loading = true) | ||
| getGroups() | ||
| } | ||
|
|
||
| fun getGroups() { | ||
|
There was a problem hiding this comment. tem algum motivo pra essa função ser pública? There was a problem hiding this comment. Sim, ele é usado no GroupTabScreen, pra quando eu adicionar um novo grupo a tela ja mostrar a lista atualizada, ai chama essa função de novo. |
||
| setAsync { | ||
| val listGroups = repository.getGroups(userRepository.get()) | ||
| logger.d("fetch ${listGroups.size} groups") | ||
| _groups.value = listGroups | ||
| it.data(data = it.data.copy(groupList = listGroups)) | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eu acho uma boa já colocar esses textos nos strings resources, porque assim evitamos que por algum vacilo a gente esqueça de remover um deles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Foi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Foi