Skip to content

Fix %20 in folder name sometimes #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix %20 in folder name sometimes #146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b024fc
Decode uri before ensuring folder creation
Jul 22, 2022
d9750a7
Cleanup
Jul 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/davros-uploader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export default class DavrosUploader extends Component {

var fullPath = ['/', this.uploadLocation, path].join('');

yield File.ensureCollectionExists(fullPath).then(() => {
yield File.ensureCollectionExists(decodeURI(fullPath)).then(() => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than encoding and then decoding, can we defer the encoding step or do it on a parallel path? (I'm actually not even sure why URI-encoding is happening in the first place.)

return file.upload('/api/upload', {
data: {
destination: fullPath,
Expand Down