feat: add --skip-submodules argument #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One could argue that this should even be the default because the submodule is managed by containing repository. If the submodule is dirty, the containing repository is dirty as well. Plus the submodule might very well not be on a branch like master but on a specific git commit and that is fine. But better not make it the default as it would change the behavior. When submodules annoy clustergit users, they can now use the --skip-submodules argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One could argue that this should even be the default because the submodule is managed by containing repository. If the submodule is dirty, the containing repository is dirty as well. Plus the submodule might very well not be on a branch like master but on a specific git commit and that is fine.
But better not make it the default as it would change the behavior. When submodules annoy clustergit users, they can now use the --skip-submodules argument