- 
                Notifications
    You must be signed in to change notification settings 
- Fork 89
Updated opm #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated opm #1019
Conversation
…flexibility. Changes: │ - Added mine_patch_grid method for systematic grid-based patch extraction │ - Refactored mine_patches to use improved label map handling │ - Updated torchio imports from typing to types module --> note, depending on the version of GANDLf you are using, you might want to undo this │ - Added comprehensive patch validation methods │ - Improved parallel processing with structured numpy arrays
…erged - Include both typing.Union import and dsa_annotations import in patch_manager.py - Include both panoptica and shapely dependencies in setup.py
| MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| This pull request updates the backend of OPM to streamline the patch extraction, add a grid mining function, and enable loading patches in memory. It also (hopefully) resolves merge conflicts between the updated_OPM branch and add_dsa_annotations_merged branch, consolidating improvements to the patch mining system with DSA annotation support. Let's see how this goes... | 
| Thanks, @grenkoca. Marking this PR as draft until we figure out the CI stuff. | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
…d mine_patch_grid
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| @check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (4)downsampled These words are not needed and should be removedASSD bdfc deac numcodecsTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the [email protected]:grenkoca/GaNDLF.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/mlcommons/GaNDLF/actions/runs/17108155948/attempts/1' &&
git commit -m 'Update check-spelling metadata'Available 📚 dictionaries could cover words not in the 📘 dictionary
 Consider adding them (in        with:
        extra_dictionaries: |
          cspell:java/src/java-terms.txt
          cspell:shell/dict/shell-all-words.txtTo stop checking additional dictionaries, add (in  check_extra_dictionaries: "" | 
| Codecov Report❌ Patch coverage is  Additional details and impacted files@@             Coverage Diff             @@
##           master    #1019       +/-   ##
===========================================
- Coverage   82.30%   69.53%   -12.77%     
===========================================
  Files         193      194        +1     
  Lines       12314    12621      +307     
===========================================
- Hits        10135     8776     -1359     
- Misses       2179     3845     +1666     
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| Stale pull request message | 

Checklist
CONTRIBUTINGguide has been followed.typingis used to provide type hints, including and not limited to usingOptionalif a variable has a pre-defined value).pip installstep is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].logginglibrary is being used and noprintstatements are left.