Fail to determine file type if url has extra params #451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you provide a URL with a extra parameters,
sceneFormatFromPath
would fail to gather what extension it could be.for example, you could have a signed url such as:
and the method
sceneFormatFromPath
would producenull
as a result, because thepath
was not curated correctly for URLs, collecting thepathname
from the url would have a better chance of gathering the possible extension type.